Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add required fields for question and checklist options #2700

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Jan 24, 2024

What does this PR do?

Previously August reported inconsistencies with how we require input for user-added fields in components.

The current behaviour for questions and checklists is that if an option is added and left blank it is deleted when the component is saved. The PR introduces required fields on user-added options for questions and checklists.

This brings it in line with the following components, which all require input on user-added fields:

  • Next steps
  • Upload + label
  • Task list
  • Confirmation (next steps)

Copy link

github-actions bot commented Jan 24, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review January 25, 2024 10:46
@ianjon3s ianjon3s requested a review from a team January 25, 2024 10:46
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for me on the pizza 👍

@ianjon3s ianjon3s merged commit be22b62 into main Jan 25, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/required-fields-question-checklist branch January 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants